Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: message set in NewStopError/NewStopErrorW not show in pod log #1619

Closed
wants to merge 1 commit into from
Closed

update: message set in NewStopError/NewStopErrorW not show in pod log #1619

wants to merge 1 commit into from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Feb 5, 2025

  • when check if erros.As() SteopError it just break to continue but the error itself not show message anywhere

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
update: message set in NewStopError/NewStopErrorW not show in pod log
53042c9 
- when check if erros.As() SteopError it just break to continue but the error
  itself not show message anywhere

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw requested a review from lburgazzoli February 5, 2025 17:25
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lburgazzoli
lburgazzoli reviewed Feb 5, 2025
View reviewed changes
pkg/controller/reconciler/reconciler.go
@@ -152,7 +152,7 @@ func (r *Reconciler) delete(ctx context.Context, res common.PlatformObject) erro
l.Error(err, "Failed to execute finalizer", "action", action)
return err
}

l.Error(err, err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is now shown as an error intentionally because it more a flag to stop the loop, not an actual error so the action is responsible to set a proper condition. Like the absence of a per-requisite is not a reconciliation error, but a condition not met.

things are going to be improved here #1605

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will have this closed

@zdtsw zdtsw closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli left review comments

@etirelli etirelli Awaiting requested review from etirelli

@MarianMacik MarianMacik Awaiting requested review from MarianMacik

Assignees
No one assigned
Labels
None yet
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @lburgazzoli